-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checking of lua sources to travis build #2423
Conversation
So found two more build errors in Lua code |
@HHHartmann Gregor normally what I do when I am working on a patch is to rebaseline against (the current) dev before pushing to my GitHub fork and issuing the PR. In my case because my patches are often big and take time, dev has usually moved on since I created my branch so this is even more needed, but we recommend this practice. Maybe for your next commit, eh? 😊 |
@TerryE Terry I do not quite understand what you ask me to do (or even not to do). Shouldn't I have merged the remote-tracking branch? I am not yet very familiar with git so I would be more than happy to be enlightened a bit more. |
@HHHartmann Gregor, it is far more important that you feel comfortable contributing which is why Marcel and I were happy to merge your PR with multiple commits. The rebasing stuff is covered here in the online Git book, but to be honest I get confused with the advanced features of git at times! Sometime I'll get a round to a simple 1-2-3 guide. |
@TerryE Terry, thanks for the link. I will read it and find out how to do it. But still I wonder what I should have done? Should it have been only one commit? Puzzled and curious. |
For a change of this size and scope I would had one or two commits, and if two then I would done the *.lua changes as one commit. |
Ah ok. |
dev
branch rather than formaster
.There are several *.lua files that are not compilable.
This PR adds checking lua files in travis builds.
Travis build will fail if there is a lua file in lua_modules or lua_samples that cannot be compiled.